Hoisting the mini-player into an outer Scaffold (previous commit)
introduced a real regression: extra space above the top header, and
a dead gap between the bottom tab bar and the mini-player.
Root cause: TopAppBar and Material3's NavigationBar (used by
BottomNavBar) are self-inset-aware - they only ever looked correct
because they sat directly at the true screen edges. Now they're
nested one level deeper inside the outer Scaffold's content area:
- The outer Scaffold has no topBar, so with its default
contentWindowInsets it fell back to reserving the raw status-bar
inset itself as top padding on the NavHost - on top of MainScreen's
own TopAppBar doing the same thing a second time.
- BottomNavBar unconditionally pads itself for the navigation-bar
inset regardless of what's below it, but MiniPlayerBar (which
already self-pads for that inset) now always sits below it - so
BottomNavBar was reserving space for an inset it's no longer
adjacent to.
Fixed by zeroing contentWindowInsets on the outer Scaffold (it has
nothing of its own to protect beyond MiniPlayerBar's already-real
measured height) and zeroing BottomNavBar's own windowInsets (since
MiniPlayerBar is now what's genuinely bottom-adjacent).
Verified on-device across Home/Library/ArtistDetail/Settings: tight
header spacing restored, tab bar sits flush against the mini-player
with no gap.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
